-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that beam basis vectors are aligned with the azimuth and zenith angle #405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 99.34% 99.35%
=======================================
Files 13 13
Lines 2141 2157 +16
=======================================
+ Hits 2127 2143 +16
Misses 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good except one typo, thanks @bhazelton !
694f1f0
to
9d059dc
Compare
Description
This adds a check that the beam basis vectors are aligned with the azimuth and zenith angle in each pixel. This is currently assumed but not checked in pyuvsim.
Motivation and Context
In the future we'd like to properly support other basis vectors (#395), but this ensures that we at least test for this and error if it's not the case.
Types of changes
Checklist:
For all pull requests:
Bug fix checklist: