Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that beam basis vectors are aligned with the azimuth and zenith angle #405

Merged
merged 8 commits into from
May 31, 2022

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented May 25, 2022

Description

This adds a check that the beam basis vectors are aligned with the azimuth and zenith angle in each pixel. This is currently assumed but not checked in pyuvsim.

Motivation and Context

In the future we'd like to properly support other basis vectors (#395), but this ensures that we at least test for this and error if it's not the case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
  • I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #405 (9d059dc) into main (c79535b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   99.34%   99.35%           
=======================================
  Files          13       13           
  Lines        2141     2157   +16     
=======================================
+ Hits         2127     2143   +16     
  Misses         14       14           
Impacted Files Coverage Δ
pyuvsim/telescope.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79535b...9d059dc. Read the comment docs.

@bhazelton bhazelton added the bug label May 25, 2022
@bhazelton bhazelton marked this pull request as ready for review May 26, 2022 20:07
@bhazelton bhazelton requested a review from steven-murray May 26, 2022 20:07
steven-murray
steven-murray previously approved these changes May 26, 2022
Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good except one typo, thanks @bhazelton !

pyuvsim/telescope.py Outdated Show resolved Hide resolved
@bhazelton bhazelton requested a review from steven-murray May 31, 2022 20:03
@bhazelton bhazelton merged commit 46ac267 into main May 31, 2022
@bhazelton bhazelton deleted the check_beam_basis branch May 31, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants