Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astropy requirement to 5.0.4 to fix IERS issue, drop python 3.7 support #397

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Apr 5, 2022

Description

Motivation and Context

Fix CI errors on other PRs related to IERS issues.
Also fixes #396

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

@bhazelton bhazelton added continuous integration packaging Issues/PRs about how pyuvsim is packaged. labels Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #397 (50c8ed1) into main (8092079) will decrease coverage by 0.61%.
The diff coverage is n/a.

❗ Current head 50c8ed1 differs from pull request most recent head c480c63. Consider uploading reports for the commit c480c63 to get more accurate results

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   99.34%   98.73%   -0.62%     
==========================================
  Files          13       13              
  Lines        2126     2126              
==========================================
- Hits         2112     2099      -13     
- Misses         14       27      +13     
Impacted Files Coverage Δ
pyuvsim/simsetup.py 98.63% <0.00%> (-1.26%) ⬇️
pyuvsim/mpi.py 99.48% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8092079...c480c63. Read the comment docs.

@bhazelton bhazelton requested a review from mkolopanis April 6, 2022 15:11
Copy link
Member

@mkolopanis mkolopanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Astropy always forcing us to update our dependencies

@bhazelton bhazelton merged commit 3b53349 into main Apr 6, 2022
@bhazelton bhazelton deleted the new_astropy branch April 6, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration packaging Issues/PRs about how pyuvsim is packaged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants