-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clearer why we think pyvusim is a reference simulator #320
Conversation
references a non-existent memo on analytic calculations, adds a list of physical effects
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 99.11% 99.23% +0.11%
==========================================
Files 12 12
Lines 1918 2083 +165
==========================================
+ Hits 1901 2067 +166
+ Misses 17 16 -1
Continue to review full report at Codecov.
|
Any reason not to merge in this doc update? |
Errant text file deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, apparently this was a pending comment rather than a posted one. Sorry!
Make lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Its not clear to the casual reader why the combination of analytic tests, continuous integration, reference simulations, documentation, community standards, and code publication adds up to pyuvsim being the root name certificate for interferometry simulators needing to demonstrate accuracy sufficient for 21cm cosmology. This pull request addresses that issue with edits to the README, addition of necessary memos, references to papers (some still in prep), and potentially, some re-organization of memos/reference simulations.
Description
Motivation and Context
Types of changes
Checklist:
Bug fix checklist:
New feature checklist:
Breaking change checklist:
Reference simulation update or replacement:
Documentation change checklist:
Version change checklist:
Build or continuous integration change checklist: