Changed log message to warning as suggested in #828 #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Please add a line to CHANGELOG.md |
|
Please rebase to master to resolve the merge conflicts. |
tmylk
reviewed
Sep 26, 2016
| @@ -2,10 +2,9 @@ Changes | |||
| ======= | |||
|
|
|||
| 0.13.2, 2016-08-19 | |||
| * export_phrases in Phrases model changed. Fixed issue #794 and added test cases in test/test_phrases.py(@AadityaJ, | |||
| [#879](https://github.com/RaRe-Technologies/gensim/pull/879)) | |||
There was a problem hiding this comment.
Please don't delete other comments in changelog.
Also please add this change to the future release 0.13.3
There was a problem hiding this comment.
Updated. Sorry for the bad commit. 👍
|
Thanks for the PR! |
This was referenced Sep 28, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have changed the info logs as given in the email mentioned in #828
Done during PyconIndia 2016