-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
129 add bayesian optimization #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkriwet Thanks for the feature!
Can you further:
- include the option in the example for optimization?
- Increase the version number to 0.5.0 due to the new feature? Also add the changelog.
@jkriwet : When doing the review, can you add the following kwarg?
|
Done. Also changed example as discussed internally |
Done |
…TH-EBC/ebcpy into 129-add-bayesian-optimization
setup.py
Outdated
@@ -13,6 +13,7 @@ | |||
'openpyxl>=3.0.5', | |||
'xlrd>=2.0.1', | |||
'pymoo==0.5.0', | |||
'bayesian-optimization==1.5.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why different version then in requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to version in the requirements. 1.5.1 works, but not for python version <= 3.9 (or 3.8). Since nothing important is changed in 1.5.1, fixing to 1.4.3 for now
…nto 129-add-bayesian-optimization
@jkriwet : Looks really nice the new feature and example! I further added markers to see which point is where. |
@FWuellhorst Thank you! Since the cma imports seemed to still make problems i have now changed the algorithmn imports and pulled them from pymoo to ebcpy. In pymoo, when choosing the algorithm over the get_algorithms() function, all algorithms are imported. Only the CMAES algorithm makes problems with the cma import. I have deleted that as an import (and algorithm choice) for ebcpy and now everything works, also in the CI for python >= 3.10. I do think the string-class relation is way more convenient and therefore dont see any reason as of yet to chang to the new pymoo version. |
Closes #129