new example added #127 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionally edit example e2 for dynamic parameter exchange via Dymola_API
|
Dear all, |
FWuellhorst
reviewed
May 3, 2024
examples/e5_modifier_example.py
Outdated
| # Start by importing all relevant packages | ||
| import pathlib | ||
| # Imports from ebcpy | ||
| from ebcpy import DymolaAPI, TimeSeriesData, FMU_API |
There was a problem hiding this comment.
FMU_API is not required.
examples/e5_modifier_example.py
Outdated
Comment on lines
55
to
59
| n_restart=-1, | ||
| equidistant_output=False, | ||
| # Only necessary if you need a specific dymola version | ||
| dymola_path=r"C:\Program Files\Dymola 2023x", | ||
| #dymola_version=None |
There was a problem hiding this comment.
We can remove these special kwargs
examples/e5_modifier_example.py
Outdated
Comment on lines
75
to
77
| # Besides parameters (explained in fmu_example), return_option is important | ||
|
|
||
| # Or change the savepath by using two keyword arguments. |
There was a problem hiding this comment.
Change the description, does not fit the current example
| return_option="time_series" | ||
| ) | ||
| print(result_sp_2) | ||
|
|
There was a problem hiding this comment.
Can you add the following code as well, showing that simulating multiple model_names works, as well? It should work, if not, please give me a note
# You can also simulate a list of different `model_names` (or modified versions of the same model)
# by passing a list to the `simulate` function in `DymolaAPI`:
model_names_to_simulate = [
"BESMod.Examples.GasBoilerBuildingOnly(redeclare BESMod.Systems.Control.DHWSuperheating control(dTDHW=10))",
"BESMod.Examples.GasBoilerBuildingOnly(redeclare BESMod.Systems.Control.DHWSuperheating control(dTDHW=5))",
"BESMod.Examples.DesignOptimization.BES",
]
results = dym_api.simulate(
return_option="time_series",
model_names=model_names
)
print(results)
There was a problem hiding this comment.
Thanks for your review @FWuellhorst ! Example script is updated und pushed to the issue branch #127
FWuellhorst
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example (e5) was added which shows how to modify parameters of simulation model (built in Modelica) with the DymolaAPI.