fix: only set model name if the model really changes and refactor to cwd #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWuellhorst
changed the title
|
Also, I added the option to only load certain variables from mats, which speeds thinks up by factors and reduces memory usage. Moreover, pathlib.Path is used for |
FelixStege
approved these changes
Feb 15, 2024
| if cd is None: | ||
| self._cd = None | ||
| if working_directory is None and "cd" in kwargs: | ||
| warnings.warn("cd was renamed to working_directory in all classes. Use working_directory instead.", category=DeprecationWarning) |
There was a problem hiding this comment.
Add a hint that cd is still used as working_directory. Unexperienced users might be confused otherwise.
Check other code occurrences as well.
There was a problem hiding this comment.
This is just backwards compatibility, cd is converted to workings_directory
|
@FelixStege thanks for the comments, I fixed them all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
Closes #61