Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct tests #133

Closed
jkriwet opened this issue Jul 10, 2024 · 0 comments · Fixed by #134
Closed

correct tests #133

jkriwet opened this issue Jul 10, 2024 · 0 comments · Fixed by #134

Comments

@jkriwet
Copy link
Contributor

jkriwet commented Jul 10, 2024

At the moment, test_simulate and test_savepath_handling always fail.

The reason for this is, that when testing the functionality of simulating and providing a new savepath for the result files, the provided savepath is equal to the working directory.

Before copying the simulation results to the provided savepath, the algorithm first deletes any existing resultfiles in that savepath. Since the savepath is equal to the working directory, the algorithm deletes the results in the working directory, before it can copy those to the savepath.

Fix is to change the provided savepath.

Functionalitywise, it should probably be checked that either the provided savepath cant be equal to the working directory or that if it is the working directory, then no copying is done.

jkriwet added a commit that referenced this issue Jul 10, 2024
@jkriwet jkriwet linked a pull request Jul 10, 2024 that will close this issue
jkriwet added a commit that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant