Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
full_output
mode.Why?
There are many works in the literature, e.g., [1], that require both bootstraping and also get the full output since they need access for instance to the mode intervals. The current implementation does not support it, necessitating the need for two distinct calls.
How?
full_output
input argument (disabled by default).classmethod
.Further Architectural Changes
The diptest 'if else' logic was rewritten to ease readability. The previous version had a lot of similar code segments, i.e.,
diptest_pval_mt
anddiptest_pval
with small argument differences.Testing?
The implementation has been tested locally in a Darwin platform and all the unittests pass with success.
Varia
It's been a long time, I hope you are fine @RUrlus :)