Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ipld.DAGService using NodeAPIClient #69

Merged
merged 2 commits into from
Apr 14, 2020
Merged

implement ipld.DAGService using NodeAPIClient #69

merged 2 commits into from
Apr 14, 2020

Conversation

xiegeo
Copy link
Contributor

@xiegeo xiegeo commented Apr 13, 2020

No description provided.

@xiegeo xiegeo requested a review from bonedaddy April 13, 2020 14:15
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #69 into master will decrease coverage by 9.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   81.56%   71.83%   -9.72%     
==========================================
  Files           7        8       +1     
  Lines         347      394      +47     
==========================================
  Hits          283      283              
- Misses         37       84      +47     
  Partials       27       27
Impacted Files Coverage Δ
go/dag_service.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e393bc5...8f4bdf8. Read the comment docs.

bonedaddy
bonedaddy approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@bonedaddy bonedaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@xiegeo
Copy link
Contributor Author

xiegeo commented Apr 14, 2020

@bonedaddy merge is still blocked, needs an approving review.

@bonedaddy
Copy link
Collaborator

@xiegeo try again I think I had some weird repo permission settings preventing people from merging

@xiegeo xiegeo merged commit 31496fb into master Apr 14, 2020
@xiegeo xiegeo deleted the DAGService branch April 14, 2020 02:27
@bonedaddy bonedaddy mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonedaddy bonedaddy bonedaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiegeo @bonedaddy