Update Configuration To Include Noise Protocol And Private Networks #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonedaddy
changed the title
xiegeo
approved these changes
Mar 13, 2020
doc/CONFIGURATION.md
Outdated
| @@ -150,6 +150,9 @@ node: | |||
| # enables the quic transport | |||
| # default is false | |||
| quic: false | |||
| # enables the noisee security transport | |||
doc/CONFIGURATION.md
Outdated
Comment on lines
168
to
171
| # enables private libp2p swarm mode | ||
| # the value here will be used as the private network shared secret key | ||
| # default is empty string ("") which means use the public network | ||
| swarm_key: 6f0cf24809cda96d0d68b0fa8abdd64eccd1b4866262040cdc5afecba3418aad |
There was a problem hiding this comment.
Should specify the format and size of the key here (32byte, hex). Also, the sample key should be a fake key or not given, otherwise it will get used unintentionally.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 7 7
Lines 347 347
=======================================
Hits 283 283
Misses 37 37
Partials 27 27Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document usage of the noise protocol, and indicate how private networks can be triggered