bsp: cvitek: continue supporting duo 256M ARM core #9835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicornx
added
BSP: Cvitek
|
@liYony 请帮忙 review，谢谢 |
|
我看你这边删除了combine.sh相关的内容，我仔细阅读了下代码，这个combine.sh主要是用于更新fip.bin用的，如果把这个脚本删除将会导致在使用arm的大核的同时，小核固件无法得到更新。 |
unicornx
force-pushed
the
dev-duo-aarch64
branch
from
2061490 to
15be7ba
Compare
|
@liYony 我根据您的意见更新了，请再 review 一下吧，谢谢。 |
smp_call.h defines SMP-related structures and declares SMP-related functions. These codes are only valid when RT_USING_SMP is defined in the bsp, which means we have to use RT_USING_SMP for judgment in every place where this file is included, such as following: ```c ``` Now move the judgment of RT_USING_SMP directly into smp_call.h, so that it's simpler to include the header file as: ```c ``` Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
For ARM, RT-smart and RT-standard both enable mmc (see rt_hw_board_init() in bsp/cvitek/cv18xx_aarch64/board/board.c, rt_hw_mmu_setup is called both for smart or standard). So ioremap is must to do for ARM. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Move the combine.sh to under cv18xx_aarch64, so we can run this script the same as scons and no need to change cwd. Rename the folder boot to prebuild just becuase all the files under boot are prebuild binaries. Move the prebuilt fip.bin to under prebuild/milkv-duo256m because it's only for 256. Update combine.sh accordingly and output fip.bin to the output folder where we create fip.bin/boot.sd as other bsp. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Re-write README.md for aarch64. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
unicornx
force-pushed
the
dev-duo-aarch64
branch
from
15be7ba to
89173c7
Compare
抱歉，好像我 git 操作有点问题，现在修复了，重新 push 了一版，请检查，谢谢。 |
liYony
approved these changes
Dec 27, 2024
Rbb666
approved these changes
Dec 30, 2024
This was referenced Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
注意：为了 review 和日后 track 方便，这个 PR 包含了四个 commit，merge 时请不要压缩，保持四个 commit 即可。
Fixed #9694。这个 PR 代替了 #9749 和 #9771，所以本 PR 合并后，这两个 PR 无需合并，可以 cancel 掉。
patch 1: cv18xx_aarch64 这个 bsp 是单核，直接在
libcpu/aarch64/common/setup.c文件中#include <smp_call.h>编译会报错说找不到rt_hw_spinlock_t定义。一种直接的解决方法是修改libcpu/aarch64/common/setup.c文件，将#include <smp_call.h>用 RT_USING_SMP 判断括起来。但讨论后不是最优解法，可以将对RT_USING_SMP的判断移到smp_call.h里面去。具体讨论见：#9771 (comment)。patch 2 ~ 3 都是针对 cv18xx_aarch64 的修改。相关背景参考 #9749。
以上 patches 的具体改动说明见各自 commit message。
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up