-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ipc: add nested-free flag support to mutex #9529
base: master
Are you sure you want to change the base?
Conversation
89eae2d
to
991ee32
Compare
498f100
to
c956a64
Compare
mutex->priority = 0xFF; | ||
mutex->hold = 0; | ||
mutex->ceiling_priority = 0xFF; | ||
mutex->ctrl_flags = ctrl_flags; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutex->ctrl_flags = ctrl_flags; | |
mutex->flag =flag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
结构体成员的名字,清晰一点为好。所以我觉得没必要改这个。
2aac7eb
to
e7bc5c0
Compare
This patch introduces a `nested-free` control flag to the mutex, allowing more flexible control over mutex hold limits. The change is necessary to handle scenarios where nested mutex acquisition is restricted, since it will introduce possibility of data corruption in a nested access to the critical area. Changes: - Added `ctrl_flags` field in `rt_mutex` structure to replace the reserved field for holding control flags. - Introduced `RT_MUTEX_CTRL_NESTED_FREE` command in `rt_mutex_control` to enable the new flag. - Refactored mutex initialization by extracting common logic into a new `_mutex_init` function, reducing code duplication. - Updated the `_rt_mutex_take` function to respect the `nested-free` flag, preventing nested acquisition when the flag is set. - Modified `rt_mutex_control` to handle the new control command and return appropriate error codes for invalid commands. Signed-off-by: Shell <smokewood@qq.com>
e7bc5c0
to
af9ecca
Compare
@mysterywolf 麻烦再review下,谢谢 |
|
如果不能给出可信理由,作者不会给出进一步修改了。多谢。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
This patch introduces a
nested-free
control flag to the mutex, allowing more flexible control over mutex hold limits. The change is necessary to handle scenarios where nested mutex acquisition is restricted, since it will introduce possibility of data corruption in a nested access to the critical area.你的解决方案是什么 (what is your solution)
Changes:
ctrl_flags
field inrt_mutex
structure to replace the reserved field for holding control flags.RT_MUTEX_CTRL_NESTED_FREE
command inrt_mutex_control
to enable the new flag._mutex_init
function, reducing code duplication._rt_mutex_take
function to respect thenested-free
flag, preventing nested acquisition when the flag is set.rt_mutex_control
to handle the new control command and return appropriate error codes for invalid commands.请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up