Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kenel] add static name for rt_object #6422

Merged
merged 8 commits into from
Dec 21, 2022
Merged

[kenel] add static name for rt_object #6422

merged 8 commits into from
Dec 21, 2022

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Sep 12, 2022

拉取/合并请求描述:(PR description)

[
增加静态object 名字,用户可以根据内存实际使用情况决定使用动态还是静态。适用于资源极度受限的情况下使用。
由于没有动态拼接支持,在静态名字下,控线线程的名字在多核时将命名成相同的名字
该功能在RT-Thread完整版本中不常用,主要用于RT-Thread Nano

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

include/rtdef.h Outdated Show resolved Hide resolved
include/rtdef.h Outdated Show resolved Hide resolved
@a1012112796
Copy link
Contributor

个人感觉这样改对于节省内存意义实在不大,或许可以考虑允许name为空指针,但list thread, find thread 等需要name的操作对此线程失效。

@mysterywolf
Copy link
Member Author

个人感觉这样改对于节省内存意义实在不大,或许可以考虑允许name为空指针,但list thread, find thread 等需要name的操作对此线程失效。

是有意义的,每一个object就要占用8个字节的内存。在一些ram受限严重的情况下,需要缩减。

@a1012112796
Copy link
Contributor

个人感觉这样改对于节省内存意义实在不大,或许可以考虑允许name为空指针,但list thread, find thread 等需要name的操作对此线程失效。

是有意义的,每一个object就要占用8个字节的内存。在一些ram受限严重的情况下,需要缩减。

可以让name 变的更短,例如 2 字节, 甚至一个字节(需要改变处理逻辑, 把name看做字符或者 0 - 255 的数字id),不是比一个指针内存占用更小 :)
其二: 如前所述,如果无法安全的让 name 成员变量指针为 const, 而 name 所指向的内存又恰好只读,就会有潜在问题。

@mysterywolf
Copy link
Member Author

mysterywolf commented Sep 13, 2022

可以让name 变的更短,例如 2 字节, 甚至一个字节(需要改变处理逻辑, 把name看做字符或者 0 - 255 的数字id),不是比一个指针内存占用更小 :)

非常有道理,那这个PR的意义就不大了,可以关闭掉了。

@mysterywolf mysterywolf deleted the name_len branch September 13, 2022 02:52
@mysterywolf mysterywolf restored the name_len branch December 10, 2022 22:03
@mysterywolf mysterywolf reopened this Dec 10, 2022
@mysterywolf
Copy link
Member Author

可以让name 变的更短,例如 2 字节, 甚至一个字节(需要改变处理逻辑, 把name看做字符或者 0 - 255 的数字id),不是比一个指针内存占用更小 :)

非常有道理,那这个PR的意义就不大了,可以关闭掉了。

还是有必要实现的,通过const char* 的方式可以不限制字符串的长度,而且只占用ROM,不占用RAM

@mysterywolf mysterywolf merged commit 061af7b into master Dec 21, 2022
@mysterywolf mysterywolf deleted the name_len branch December 21, 2022 03:36
@yuqingli05
Copy link
Contributor

如果应用中 存在 char* 类型的 是不是就不能用这个了? cahr 会被外部改变

@mysterywolf
Copy link
Member Author

如果应用中 存在 char* 类型的 是不是就不能用这个了? cahr 会被外部改变

不取决于数据类型,取决于数据的内存类型,如果这个字符串是全局变量,是可以放进去的,如果是函数的局部变量是不可以的。

@mysterywolf
Copy link
Member Author

TODO:

  1. 确保shell组件在RT_NAME_MAX为0时可以正确工作
  2. Kconfig的range调整为1-64,Nano内核不使用Kconfig构建,因此完整RT-Thread中禁止使用本功能。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants