Fix threading issue with external links in HTML5 contexts #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mention the threading requirements in the docs - Check that the browse action is supported before we try to use it - Avoid needlessly reparsing the URI
cwisniew
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5077
Description of the Change
The click handler for HTML5 links now calls
MapTool.showDocument()on the swing thread to avoid conflicts with the JFX thread where the handler runs.We also now check that the browse action is supported by the
Desktopbefore entering the associated code branch.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is