Decompose Grid.getShapedArea() so we can reuse logic between grids
#4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
added
bug
code-maintenance
We now calculate these things separately: 1. Which way the token is facing on the grid. 2. The shape of the light itself. 3. The shape of the token's footprint contribution to the light (for cones). With this we gain the following benefits: 1. `IsometricGrid` can reuse the main shape logic and just transform the result. No more duplicated logic. 2. The code should be more approachable as each method does One Thing™. Lights on isometric grids act literally the same as for square grids, just rotated and foreshortened. This fixes some related bugs, e.g., beams not getting visually shorted when vertical. It also means iso grids now have a full set of accurate lights available, e.g., hexes no longer default to ellipses.
kwvanderlinde
force-pushed
the
feature/4980-iso-shape-completeness
branch
from
ff3de9a to
cc98fef
Compare
bubblobill
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4980
Description of the Change
This refactors
Grid.getShapedArea()for more consistency between grid types. The main goal was to allowIsometricGridto reuse the main logic and transform the results rather than having to duplicate and specialize most of the logic for its unique circumstance.With this change, isometric grid lighting behaves the same as for other grid types, save for the footprint area and 45° difference in the meaning of token facing. This means hex lights render as hexes, and beams are properly foreshortened. It also means no special logic for the other shapes, so we can be more confident that those will remain consistent into the future.
Possible Drawbacks
None. Unless folks want to complain about hexes being hexagonal.
Documentation Notes
N/A
Release Notes
This change is