Fix note rendering when labels are present. #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`renderZone()` now uses a copy of the graphics object so that `paintComponent()` isn't affected by any changes. This also means no need to restore graphics state (rendering hints, clip, etc) at the end of `renderZone()`. Beyond being more reliable, this avoids a bug in `Graphics2D`, where `setRenderingHints()` does not properly detect font state changes, unlike `setRenderingHint()`. We used to use `setRenderingHint()` but hit this bug since moving to `setRenderingHints()`.
bubblobill
approved these changes
Dec 13, 2023
cwisniew
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves #3691
Description of the Change
With the switch to
setRenderingHints()for restoring graphics state, we ran into a bug inGraphics2Dwhere its cached font state is not invalidated since it doesn't detect that a change has occurred. This causes the wrong state to be used back inpaintComponent(), but only if the problematic state is in play (e.g., if a label has been rendered).The new approach has
renderZone()work on a copy of theGraphics2Dobject, so thatpaintComponent()isn't affected by any changes to its state. This also removes the need forrenderZone()to reset any state, including rendering hints and clips. To be sure it works properly,paintComponent()has to set its font prior to rendering the notes now.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is