Fix google-java-format invocation #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
changed the title
|
Sorry for being so loose here. I meant to make a PR against my own repo. But now that it's made, I'll just fix things up and then bring this PR up to standards. |
kwvanderlinde
force-pushed
the
bugfix/3848-google-format-invocation
branch
from
e3ec39a to
67c43ff
Compare
kwvanderlinde
force-pushed
the
bugfix/3848-google-format-invocation
branch
from
67c43ff to
d0aad89
Compare
|
This is ready for review now. |
Phergus
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #3848
Description of the Change
The
--replaceflags has been removed so that there is no longer a conflict with--dry-run.I would have liked to also add
--set-exit-if-changedso that the build would fail on formatting violations, but the google-java-format requirements differ from the spotless requirements, so we can't have both at the moment.Possible Drawbacks
Shouldn't be any.
Documentation Notes
N/A
Release Notes
N/A
This change is