Feature reduce deps #3807
Merged
Feature reduce deps #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thelsing failed spotless |
|
I didn't think that I could introduce spotless errors in such a simple code change ... |
Phergus
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Reviewed 14 of 15 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thelsing)
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #1056
Description of the Change
I removed all dependencies that I could. I also updated the logging code to use the log4j 2 api. I also added comments what we use which lib for. Finally I updated the gradle wrapper to the current version.
Possible Drawbacks
Some dependencies still get pulled by other libs we use. When we remove the libs that pull them in we have to readd them.
Release Notes
I don't think that this needs to be mentioned.
This change is