Missing internationalisation strings #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Crowdin updates
Correct typo on offset.
Additional fix for #3703.
Fixes for Adjust Grid panel bugs
Rather than try to pass a null through the DTO process, added new update type for removeFacing that doesn't take a parameter.
Fix for NPE when using removeTokenFacing()
|
@cwisniew That was my plan as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #2837
Description of the Change
Introduce (or point to pre-existing) internationalisation tokens for non-empty items in the Token Dialog screens (new and edit modes). Add the English versions - these are just copies of the previously hardcoded values.
Possible Drawbacks
None
Documentation Notes
Additional fields (most notably those on the token Hero options tab) can be translated now
Release Notes
Ensure all strings used in the Token Dialog screens are translatable.
This change is