Fix NPE when using the createTable macro function #3511
Conversation
There was a problem hiding this comment.
I suspect that someone put the getInternalEntryList() there as the object was been deserialized somewhere and that was not initialising the variable with an empty array, but instead of a readResolve or similar this was resorted to.
The change to prodobuf probably removes the initial serilaization issue this was "resolving" if no errors are now being experienced after removal. If this works and introduces now new NPE errors on sending/reciving(or using after those) tables on the client end I am ok with change.
|
Yeah, that makes perfect sense. I did make sure to test a bit and have not yet encountered any issues with creating or manipulating tables (through macros or the UI) or loading campaigns I have that have tables, as a host or connected client. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Irarara)
Identify the Bug or Feature request
Fixes #3510, related to #3254
Description of the Change
This ensures that
entryListinLookupTableis properly initialized (and removes the rather superfluousgetInternalEntryList()).Possible Drawbacks
None, unless I missed some undocumented importance of
getInternalEntryList().Documentation Notes
N/A
Release Notes
N/A
This change is