Issue 3254 protobuf null pointer exceptions #3353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves #3254
Description of the Change
There are several model types that have fields that aren't expected to be
null
but which can be madenull
as a result of deserialization. This made it impossible to open many campaign files, possibly also affecting other actions that require deserialization. This changes primarly adds or modifiesreadResolve()
methods for various model types to avoid undesirablenull
s.A couple smaller fixes are also included:
null
exposed area GUIDs by ignoring them while serializing.Possible Drawbacks
Shouldn't be any drawbacks in behaviour. There may be a better way to handle deserialization with missing /
null
fields that could avoid some of these checks.Skipping the
null
keys forZone.exposedAreaMeta
is kind of the wildcard in this change. Those keys shouldn't be possible and yet they exist, so maybe there could be some edge case where they can be read back out again.Documentation Notes
N/A
Release Notes
N/A
This change is