Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPEs in protobuf conversion #3288

Merged
merged 5 commits into from
Jan 15, 2022
Merged

Conversation

thelsing
Copy link
Collaborator

@thelsing thelsing commented Dec 16, 2021

Identify the Bug or Feature request

related to #3254

Description of the Change

fixes NPEs. Tested Messages:
Heartbeat
SetCampain
PlayerConnected

Maybe we should rename the 1.13 branch to protobuf and squash-merge it into develop before 1.13. I guess there will be more fixes.


This change is Reviewable

@cwisniew
Copy link
Member

@thelsing there are a few

if (blah) do_something();

Can you please update to meet the coding standard

if (blah) {
   do_something();
}

I wish spotless google java plugin would enforce that rule but even though that is one of the rules for that format it doesnt enforce/reformat it.

Just makes things easier to read if everyone is doing the same thing.

We can merge this branch with develop after 1.12 which will probably be early to mid Jan (as protobuf stuff probably wont be tested enough for that release)

@thelsing
Copy link
Collaborator Author

thelsing commented Dec 23, 2021

I think it't best it this PR stays open until I test all messages. But on the other side: I can alway create a new PR.

@Phergus
Copy link
Contributor

Phergus commented Jan 14, 2022

Just FYI, I'm going to leave this PR open as you requested until you tell me otherwise.

@thelsing
Copy link
Collaborator Author

I tested everything I can. So I think this should be merged into the release-1.13 branch. I have no idea how to test the ExecLink or ExecFunction and the non tested add-on messages in #3254
I would appreciate any help there.

@Phergus Phergus changed the title fix NPEs Fix NPEs in protobuf conversion Jan 15, 2022
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 9 files at r1, 8 of 12 files at r2, 3 of 7 files at r3, 13 of 13 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @thelsing)

@Phergus Phergus merged commit 938a259 into RPTools:release-1.13 Jan 15, 2022
@Phergus
Copy link
Contributor

Phergus commented Jan 15, 2022

I have no idea how to test the ExecLink or ExecFunction and the non tested add-on messages in #3254

Not really functionality I've ever used but I'll see if I can throw something together for some basic testing.

@thelsing thelsing deleted the develop branch January 22, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants