Is number fix3191

[Phergus]

Identify the Bug or Feature request

Resolves #3191

Description of the Change

As part of the test, whitespace padding is removed as is the first leading '+' character if present.

Possible Drawbacks

Macros written after MT 1.7 and using isNumber() may produce different results now.

Documentation Notes

isNumber() trims whitespace from the passed in string and strips off the first leading '+' character if present before evaluating whether or not the string contains a valid number.

Release Notes

• Macro function isNumber() will now evaluate strings with leading/trailing whitespace or single leading + characters returning true for numeric strings.

---

This change is 

[Azhrei]

The docs for Integer.parseInt() indicate that a single leading minus sign or plus sign will be handled properly. If that's true, then stripping off a plus sign would allow a number such as ++5 to be treated as positive 5 and +-5 to be treated as negative 5.

Be sure to add tests for strings such as those.

(I'm basing this on the docs for NumberUtils.isParseable() and its references.)

[Phergus]

@Azhrei passing +5 to NumberUtils.isParseable() returns false so, with the code as submitted, passing ++5 will return false after the first '+' is stripped off. Doesn't make sense to me to expect strings with an arbitrary number of '+' characters to be treated as numbers. The code for isParseable() explicitly handles a leading minus sign but returns false with 2 or more.

[kwvanderlinde]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)