Update ServerPolicy.java

[Phergus]

Identify the Bug or Feature request

Completes #3073

Description of the Change

Added server name, port#, WebRTC & Use Password File to result of getInfo("Server").

Possible Drawbacks

none anticipated

Documentation Notes

{
  "tooltips for default roll format": 0,
  "GM reveals vision for unowned tokens": 0,
  "players can reveal": 1,
  "auto reveal on movement": 1,
  "movement locked": 0,
  "token editor locked": 0,
  "restricted impersonation": 1,
  "individual views": 1,
  "individual fow": 0,
  "strict token management": 1,
  "players receive campaign macros": 1,
  "movement metric": "ONE_TWO_ONE",
  "using ai": 1,
  "vbl blocks movement": 1,
  "timeInMs": 1634844758285,
  "timeDate": "2021-10-21 13:32:38",
  "gm": ["GM"],
  "hosting server": 1,
  "personal server": 0,
  "useWebRTC": 0,
  "usePasswordFile": 1,
  "server name": "Z is for Zombie",
  "port number": 51234
}

Release Notes

• getInfo("Server") now includes server name, port#, WebRTC & Use Password File

---

This change is 

[cwisniew]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Phergus)

[thelsing]

Did you update the protobuf for handshake? May not be necessary but maybe you just forgot.

[cwisniew]

@thelsing the values don't actually live in the server policy, and none of these needs to be sent to clients really. It's just unfortunate that whomever added the code to extract the json for MT Macros put it in this class, some day this should really be cleaned up :)

[Phergus]

@cwisniew that is a mess.

[thelsing]

The usePasswordFile field should be added to the protobuf Dto even if this property is not needed on the client side. We should try to keep the mappings and protobuf definitions and the objects in sync. Is this property used somewhere? If not why was it added in this PR? ;)

[Phergus]

Is this property used somewhere? If not why was it added in this PR? ;)

Because I screwed up. I had put that in earlier thinking it wasn't being tracked anywhere and then later forgot to take it back out before the commit. I'll put in a fix for it.