-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ui for player password support #2992
add ui for player password support #2992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)
Requirements for Contributing a Bug Fix or Enhancement
and possibly closure of the pull request if it is not provided after this request.
Identify the Bug or Feature request
resolves #2908
resolves #2913
resolves #2916
Description of the Change
This PR resolves the remaining issues for #2907 adding a UI for maintaining players in the player database. An API for the player database is also part of this PR to enable macro access in the future (it is already in use as part of the UI changes).
Possible Drawbacks
This is potentially going to generate an uptick in support requests when people start using this.
Documentation Notes
I have created a post describing how this feature works/can be used
https://rptools-doc.craigs-stuff.net/blog/player-databases
This is hopefully enough to get people started with the feature and can serve as the basis for a new page on the wiki.
Release Notes
This change is