Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ui for player password support #2992

Merged
merged 21 commits into from
Oct 1, 2021

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Oct 1, 2021

Requirements for Contributing a Bug Fix or Enhancement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in timely manner will result in a request for you to update the pull request
    and possibly closure of the pull request if it is not provided after this request.
  • After you create the pull request, all status checks must pass before a maintainer will review your contribution.

Identify the Bug or Feature request

resolves #2908
resolves #2913
resolves #2916

Description of the Change

This PR resolves the remaining issues for #2907 adding a UI for maintaining players in the player database. An API for the player database is also part of this PR to enable macro access in the future (it is already in use as part of the UI changes).

Possible Drawbacks

This is potentially going to generate an uptick in support requests when people start using this.

Documentation Notes

I have created a post describing how this feature works/can be used
https://rptools-doc.craigs-stuff.net/blog/player-databases
This is hopefully enough to get people started with the feature and can serve as the basis for a new page on the wiki.

Release Notes

  • Added player database which allows per user password or public key authentication

This change is Reviewable

@cwisniew cwisniew changed the title add dialog add ui for player password support Oct 1, 2021
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants