Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ways to access theme information for the current client via macros. #3057

Closed
melek opened this issue Oct 15, 2021 · 7 comments
Closed

Add ways to access theme information for the current client via macros. #3057

melek opened this issue Oct 15, 2021 · 7 comments
Assignees
Labels
feature Adding functionality that adds value

Comments

@melek
Copy link
Collaborator

melek commented Oct 15, 2021

Is your feature request related to a problem? Please describe.
I want to create add-ons that fit into the MapTool User Interface beautifully (or at least seamlessly), but currently I can't dynamically adapt the colors from the current theme to my UIs.

Describe the solution you'd like
I want some way to access colors/values from the TinyLAF theme that is loaded at MapTool Startup for the client my macros run on. Preferably this would be pretty fast, so I wouldn't have to cache them ahead of time or something like that.

Perhaps this could be appended to getInfo("client").

Describe alternatives you've considered

  • Leave out people with MapTool themes which clash with my add-ons, accessibility be damned.
  • Create 'dark mode', 'high contrast mode', 'large font mode', or similar features/themes for users to select from. Encourage others to do the same, so that you have as many places to select UI themes as you do add-ons, creating opportunities to craft a hideous visual menagerie.

Additional context
There are some requests that would impact this one:

Unless this request is trivial, If a more advanced approach to theming like in those requests above is in the pipeline this one can probably be merged or tabled until those are more mature.

@melek melek added the feature Adding functionality that adds value label Oct 15, 2021
@Phergus
Copy link
Contributor

Phergus commented Oct 28, 2021

Here is a dump of what you would get for all the colors used by a theme and where they are used.

ThemeColorDump.json.txt

@melek
Copy link
Collaborator Author

melek commented Oct 28, 2021

That is awesome, thank you!

Definitely would create a wiki page to help folks map that in their designs and recommend TinyLAF editor as an assistive tool if they need more reference.

@Phergus
Copy link
Contributor

Phergus commented Oct 29, 2021

Wiki page for getInfo() updated with "theme" option.

https://wiki.rptools.info/index.php/getInfo#Retrieve_theme_Information

@FullBleed
Copy link

Will we be able to set these theme elements by macros?

Tinylaf does not seem to offer access to all of these elements (probably why some of the text colors in, for example, the Dark Theme are not optimal). A more custom, in-tool theme editor would be desirable.

@melek
Copy link
Collaborator Author

melek commented Oct 29, 2021

Will we be able to set these theme elements by macros?

Tinylaf does not seem to offer access to all of these elements (probably why some of the text colors in, for example, the Dark Theme are not optimal). A more custom, in-tool theme editor would be desirable.

Given that right now we have to restart MapTool to change themes, I think dynamically changing the theme is contingent on something like #1248

@Phergus
Copy link
Contributor

Phergus commented Oct 29, 2021

Will we be able to set these theme elements by macros?

Nope. No plans to do so.

@FullBleed
Copy link

Given that right now we have to restart MapTool to change themes, I think dynamically changing the theme is contingent on something like #1248

I'm not really concerned with changes being dynamic (though there has been some waffling on whether this is actually not possible.) I am interested in getting at elements that tinylaf doesn't though.

@Phergus Phergus closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

No branches or pull requests

3 participants