Add Advanced Theme Support

[Phergus]

Is your feature request related to a problem? Please describe.
A continuation of the work started in #921 .

Describe the solution you'd like

What remains to be done

Change theme to be represented by a directory under .maptool-rptools/themes/ui
The directory structure should contain

• theme.json - A json file which contains:
  • theme name
  • mapping from icon names to icon file names
• mylaf.theme - A TinyLaF theme file.
• icons - A directory.
  • all the icon files

A new class ThemeSupport which will read the directory and json file above and provide methods to get the image for the different icons, and the file name for the tinylaf theme. The uses of the public static fields to retrieve images or image names for the UI need to be changed to use ThemeSupport.

Context
See #921 for more discussion of icons and such.

[Azhrei]

It looks like a PR for this must have been merged but this ticket was never closed...?

In any case, the existing code is installing the UI themes every time MapTool starts (on macOS using MT 1.6.1). In fact, the log file (attached) shows it happening twice at every startup.

maptool.log

[cwisniew]

It looks like a PR for this must have been merged but this ticket was never closed...?

Work hasn't started on this issue as its to expand the current behaviour.

In any case, the existing code is installing the UI themes every time MapTool starts (on macOS using MT 1.6.1). In fact, the log file (attached) shows it happening twice at every startup.

maptool.log

At the moment it updates on every start as its quick and guarantees users have latest updates to a theme without having to track first run of a version. Probably likely to happen in the future too.

The double install is a bug that needs to be addressed (although thankfully a minor one that can wait for this issue to be picked up if no one wants to tackle it first).

[nmeier]

I like the icon pack idea - if there is a toolkit that builds the scaled .png images out of checked in svg files, and assembles them at runtime into an appropriate scaled choice, that would make creating those packs very easy. One button -> one svg image to provide. Compile the pack into resource pack, render selection, disabled, theme color etc. automatically.

I'd be willing to help out. Would need help to categorize the existing icons and find svg candidates.

[Azhrei]

... if there is a toolkit that builds the scaled .png images out of checked in svg files, and assembles them at runtime into an appropriate scaled choice, ...

Agreed.

Ideally, the results would be added to the AssetManager so that they are put into the asset cache and don’t need to be calculated again.

[mrkwnzl]

@nmeier Let me know if I can help finding, converting or editing some of the icons.

[nmeier]

Keeping this link here as well https://game-icons.net/

Planning to assess and list out all current tool icons - maybe put them in a google sheet to review. Then think about how a theme can look like that supports the icons at least.

[bubblobill]

Should this be closed now?