Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection #63

Closed
wants to merge 41 commits into from
Closed

Collection #63

wants to merge 41 commits into from

Conversation

JustSimplyKyle
Copy link
Contributor

No description provided.

SiongSng and others added 30 commits August 27, 2023 18:27
Copy link

github-actions bot commented Nov 18, 2023

Download the artifacts for this pull request:

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 452 lines in your changes are missing coverage. Please review.

Comparison is base (90d30ac) 59.72% compared to head (971691a) 42.95%.

Files Patch % Lines
...alog/create_collection/collection_information.dart 1.72% 114 Missing ⚠️
...dialog/create_collection/collection_game_mode.dart 1.73% 113 Missing ⚠️
...nect_ui/lib/components/misc/era_dropdown_menu.dart 0.00% 101 Missing ⚠️
...og/create_collection/create_collection_dialog.dart 2.38% 41 Missing ⚠️
app/lib/dialog/setup/setup_dialog.dart 37.50% 25 Missing ⚠️
.../era_connect_ui/lib/components/misc/era_field.dart 0.00% 15 Missing ⚠️
...connect_ui/lib/components/misc/era_text_field.dart 0.00% 15 Missing ⚠️
app/lib/dialog/setup/collection_addition.dart 11.11% 8 Missing ⚠️
...ui/lib/components/dialog/dialog_rectangle_tab.dart 0.00% 7 Missing ⚠️
app/lib/dialog/login_account_dialog.dart 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #63       +/-   ##
===========================================
- Coverage   59.72%   42.95%   -16.77%     
===========================================
  Files          37       46        +9     
  Lines         946     1441      +495     
===========================================
+ Hits          565      619       +54     
- Misses        381      822      +441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JustSimplyKyle
Copy link
Contributor Author

In favor of
#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants