-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support macOS bundling for binary distribution #5367
Conversation
No point while the issues mentioned in #5361 are still prevalent, it would just be wasting server space. |
The disk space is provided by github, so I am not positive it is to be taken into account. Despite the issues (yes, I am fully aware about them), we will be able to track that the binaries run at the very least, which I believe is fairly important. |
I've talked with Ani (one of the admins) and he said he's okay with publishing binaries to GitHub, we're just waiting on Nekotekina to create RPCS3/rpcs3-binaries-mac |
Right, in fact there is one more issue. I wanted to address it in the beginning, but unfortunately failed to implement. I believe MoltenVK, despite not working as of now, is no less mature than gfx portability at the very least, and wanted to support them both. My original idea is to weak link ( For this reason, the way to select the Vulkan implementation is fairly open. We could always patch/symlink the vulkan library within rpcs3.app itself, but it will break codesigning if it is considered. |
This comment has been minimized.
This comment has been minimized.
Rebased the branch with latest master. @Nekotekina, I believe we should merge this even if we postpone the binary distribution for macOS. The changes contain several platform-specific improvements and I see no reason not to have them. Currently nothing prevents us from uploading binary files for macOS, yet it can (should) be a separate pull request. |
Polished macOS compilation to properly generate an app file that can be distributed in binary form. Also fixed broken style support and freezing error messages.
While macOS binaries are not very decent, I believe they can be uploaded to the website for better tracking. Could anybody create another PR by zipping
rpcs3.app
inbuild/bin
and uploading it where necessary?Note: it appears that the CI failed to pull some environment data on Linux, and the build needs to be restarted to pass.