Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard pad handler segfault #16208

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix keyboard pad handler segfault #16208

merged 2 commits into from
Oct 14, 2024

Conversation

Megamouse
Copy link
Contributor

  • Fix segfault caused by lockless std::move of stick vector (copy keeps the same memory)
  • Use std::array for sticks, sensors and motors. We always have the same amount of those. So using a vector has always been a bit confusing.

fixes #16207

@Megamouse
input: fix segfault caused by lockless std::move of stick vector
cf57dcf 
The copy assignment seems to fix this
@Megamouse
input: use std::array for sticks, sensors and motors
903d492 
We always have the same amount of those.
So using a vector has always been a bit confusing.
@Megamouse Megamouse changed the title Fix pad handler segfault Fix keyboard pad handler segfault Oct 14, 2024
@Megamouse Megamouse merged commit 7b92cbc into RPCS3:master Oct 14, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix Input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression] Keyboard pad handler is causing the emulator to forcibly close with no error
1 participant
@Megamouse