-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPU: Make GETLLAR always accurate #15654
Conversation
4365a62
to
1f79ba7
Compare
Ready for testing! |
RPCS3.log |
611525c
to
2a90471
Compare
Fixed! Also, YAKUZA: DEAD SOULS no longer requires accurate GETLLAR on default settings! |
Crashed in MGO after entering the title screen. Only happened on the first boot.
|
Same freeze/hang before intro in MGSV GZ and TPP MGSV Ground Zeroes: MGSV The Phantom Pain: |
Following #15652, the reason for PUTLLC16 optimization to cause regressions was that the fat (old form) PUTLLC was, making GETLLAR accurate by providing additional checks for the data retrieved from the CELL memory.
Here we can kill two birds with one stone, from now on GETLLAR would be accurate (aside from the corner case which is side effects of operations on GETLLAR within the atomic loop scope - which is why I don't drop the setting altogether) and that PUTLLC16 optimization would be put in place.
Aims to fix (WIP):
Fixes #15652
#15645#15644#15635Edit: At the end I decided the make accurate GETLLAR the default because there is no really a performance hit with it on. (it made more sense back in TSX days in which any additional memory touching counted)