Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSX: Multi-context support [part 1] #15421

Merged
merged 8 commits into from
Apr 13, 2024
Merged

RSX: Multi-context support [part 1] #15421

merged 8 commits into from
Apr 13, 2024

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Apr 10, 2024

First part of multi-context work. We start by basically refactoring everything into manageable logical units. This refactor focused more on separating the hardware bits but a lot more work is needed in the "thread" since it grew into a monstrosity.
The concept of a hardware context is introduced though currently not used.

#15424

Still WIP, linux/BSD/apple support is not yet ready.

@kd-11 kd-11 changed the title RSX: Multi-context support [part 1] [WIP] RSX: Multi-context support [part 1] Apr 10, 2024
@Linear524
Copy link

We believe in you, KD-11 ! :)
RSX should be fully and accurately emulated in order to fix remaining issues in PS3 emulation...

@Megamouse Megamouse added RSX Refactoring Refactors or simplifies existing code labels Apr 11, 2024
@kd-11 kd-11 changed the title [WIP] RSX: Multi-context support [part 1] RSX: Multi-context support [part 1] Apr 11, 2024
@kd-11 kd-11 marked this pull request as ready for review April 11, 2024 22:01
@kd-11 kd-11 merged commit d6f6752 into RPCS3:master Apr 13, 2024
4 of 6 checks passed
@Augusto7743
Copy link

Augusto7743 commented Apr 15, 2024

@kd-11
That PR is about optimization too ?
Tested not games having slowdown. Several are with same performance, but I see Tekken 5 DR having more 10 % FPS. Need test other games.
Another strange detail with that PR are happening an "rendering ahead" in some games.
For example. Start an game in first screen is the game company logo and second screen the game title. When in first screen being rendered the game company logo in background are being rendered transparent flickering graphics from second screen as if are being rendering ahead in current screen.
Have another users seeing that issue too ?

@kd-11
Copy link
Contributor Author

kd-11 commented Apr 15, 2024

@kd-11 That PR is about optimization too ? Tested not games having slowdown. Several are with same performance, but I see Tekken 5 DR having more 10 % FPS. Need test other games. Another strange detail with that PR are happening an "rendering ahead" in some games. For example. Start an game in first screen is the game company logo and second screen the game title. When in first screen being rendered the game company logo in background are being rendered transparent flickering graphics from second screen as if are being rendering ahead in current screen. Have another users seeing that issue too ?

There should be no visible changes. There are some improvements related to FIFO reordering (optimization) since it was broken before. If you're seeing visual problems let us know, visual output should have remained the same.

@Augusto7743
Copy link

Thanks for your reply.
I will clean the RPCS3 cache path and create PPU new modules using that PR and after test with some games.
After post result here.

@Augusto7743
Copy link

Augusto7743 commented Apr 16, 2024

Cleaned all caches. Created new PPUs modules for that PR build.
Tested in an AMD FX 6300 six core six threads. That cpu is sensitive with PR doing better performance.
Using disable custom vulkan allocator because the GPU is an GT 640 and comparing that setting enabled or disabled is the same performance. Disabling that setting save ram usage.
Games are in ISO format mounted using GCDEMU.

Choplifter HD NPUB30619 when starting in load screen randomly happen the bug "rendering ahead". Before the correct screen loading sequence is showed an screen with flickering graphics from game title in few miliseconds. Hard to do an screenshot.
Related with #15455 ?

Burnout Paradise NPUB30040 has much better performance with that PR. Never before was possible in some moments reach gameplay 100 % speed in AMD FX. Now with that PR run in several moments in 100 % =)
ELEVATOR ACTION DELUXE NPUB30428 are an bit more faster.
Gran Turismo 5 Prologue Spec 3 shaders creation are being smooth compared with previous build. That game does much usage of spus for graphics. Performance is similar with previous build.
MOTORSTORM APOCALYPSE NPUA80661 are an bit more faster.

Other games are with same performance. Perhaps your code in FIFO reordering ?

That PR not does slowdowns. Some games are with better performance and more stable.
Possibly testing in current high end will show an better performance improvement.
The file zip has logs of games above.

THANKS VERY MUCH KD-11 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
YOU HAVE DONE AGAIN !! =)

rpcs3.zip

@OlegVolgin
Copy link

OlegVolgin commented Apr 17, 2024

Related with #15455

@Augusto7743 I'll check it as soon as I will be home after my job

@OlegVolgin
Copy link

Related with #15455

@Augusto7743 I'll check it as soon as I will be home after my job

so yeah, it didn't work out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Refactors or simplifies existing code RSX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants