Update libpng to 1.6.42 #15159
Merged
Update libpng to 1.6.42 #15159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
added
the
Build and CI
Megamouse
force-pushed
the
update_libpng
branch
2 times, most recently
from
acfebed
to
86e1f6c
Compare
Megamouse
force-pushed
the
update_libpng
branch
from
86e1f6c
to
7b19165
Compare
oltolm
reviewed
Feb 6, 2024
| @@ -15,4 +14,6 @@ else() | |||
| target_link_libraries(3rdparty_zlib INTERFACE zlibstatic) | |||
| target_include_directories(3rdparty_zlib INTERFACE zlib ${CMAKE_CURRENT_BINARY_DIR}/zlib) | |||
| target_compile_definitions(3rdparty_zlib INTERFACE -DZLIB_CONST=1) | |||
|
|
|||
| set(ZLIB_ROOT ${CMAKE_CURRENT_BINARY_DIR}/zlib PARENT_SCOPE) | |||
There was a problem hiding this comment.
I don't think that this does anything. ZLIB_ROOT is searched at configuration time, but it is populated at build time, so at configuration time it will be empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is separate from the other submodules due to potential build issues