-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing headers #15075
Add missing headers #15075
Conversation
3rdparty/pine/pine_server.h
Outdated
@@ -27,7 +27,7 @@ | |||
#include <sys/un.h> | |||
#include <arpa/inet.h> | |||
#include <poll.h> | |||
#if defined(__DragonFly__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__APPLE__) | |||
#if defined(__DragonFly__) || defined(__FreeBSD__) || defined(__linux__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__APPLE__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just do #ifndef MSVC
or #ifndef _WIN32
at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, it's right above this. Why was this even separated lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a platform check, _WIN32 would be the right define to check for.
4176a8b
to
e4b15c0
Compare
Some systems must explicitly include these headers.
e4b15c0
to
93dfa3f
Compare
RPCS3/rpcs3#15075 Related: #259 Signed-off-by: Andrew Udvare <audvare@gmail.com>
Some systems must explicitly include these headers.
Reported by: https://bugs.gentoo.org/922263