Windows: file path fixes #15043
Merged
Windows: file path fixes #15043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Megamouse
commented
Jan 13, 2024
Megamouse
commented
- Use fs::get_temp_dir during updates, GetTempPathW was falsely using size in bytes instead of string length.
- Remove duplicate to_utf8 function in fs::file
- Move buf in fs::get_config_dir from stack to heap to silence some VS warning
Megamouse
added
Bugfix
Filesystem
Refactoring
elad335
reviewed
Jan 13, 2024
GetTempPathW was falsely using size in bytes instead of string length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.