PPUAnalyser: fix std::move misuse #14011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Jun 12, 2023
| @@ -1539,7 +1543,7 @@ bool ppu_module::analyse(u32 lib_toc, u32 entry, const u32 sec_end, const std::b | |||
| end = 0; | |||
| } | |||
|
|
|||
| for (auto&& [_, func] : as_rvalue(std::move(fmap))) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Nekotekina
reviewed
Jun 12, 2023
rpcs3/Emu/Cell/PPUAnalyser.cpp
Outdated
| @@ -665,8 +665,8 @@ bool ppu_module::analyse(u32 lib_toc, u32 entry, const u32 sec_end, const std::b | |||
| break; | |||
| } | |||
|
|
|||
| const u32 addr = ptr[0]; | |||
| const u32 _toc = ptr[1]; | |||
| const u32& addr = ptr[0]; | |||
There was a problem hiding this comment.
Idk, from experience const ref is faster even for simple types.
Or can it change here?
There was a problem hiding this comment.
References should be avoided as it's fragile. It may not always result in reference binding. For instance it's not even obvious what it does here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an unwanted - or at least mishandled - std::move of the ppu function map in ppu_module::analyse.
The object is used later again, so this seems like a bug to me.