Round squircled axis values to the nearest whole number #13671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the default squircle value of 8000, I observed the following behavior:
ConvertToSquirclePoint(128,128) --> (128,128). This makes sense to me.ConvertToSquirclePoint(127,127) --> (126,126). Huh.If you don't cast the coordinate values to integer, you get the following:
ConvertToSquirclePoint(128,128) --> (128.0625, 128.0625)ConvertToSquirclePoint(127,127) --> (126.9375, 126.9375)To me, it makes sense to round the coordinate values to the nearest whole number instead of just casting them to integers. This way, joysticks centered at (127,127) remain centered at (127,127) instead of getting recentered to (126,126).
Implementing this allows me to implement #13636 without having to workaround joysticks being centered at (126,126).