Overlays: Add a selection of dynamic settings to the home menu #13368
Conversation
Megamouse
commented
Feb 6, 2023
Megamouse
commented
- Implements home menu pages
- Implements home menu message box
- Adds current date and time to top-right corner of the home menu
- Adds dynamic settings to the new settings pages in the home menu
- Allows saving the custom config by pressing square and accepting the message box
- Allows discarding the settings' changes by pressing triangle and accepting the message box
Megamouse
force-pushed
the
mmmmmmm
branch
6 times, most recently
from
68381be
to
c40ed1a
Compare
| temp.file.write(settings.c_str(), settings.size()); | ||
| if (!temp.commit()) | ||
| { | ||
| sys_log.error("Could not save config to %s (error=%s)", config_name, fs::g_tls_error); |
There was a problem hiding this comment.
Add a system notification message as well. If the user has fullscreen, they won't know that settings didn't save.
There was a problem hiding this comment.
Idk. why would it fail to save in the first place?
Seems like an arbitrary point to add a localized notification...
There was a problem hiding this comment.
Well, if we notify users when the setting saves then they will be more inclined to realize that settings have not saved if they close the emu while something is runing or they exit out of the guide menu without saving. Otherwise i agree
There was a problem hiding this comment.
Idk. why would it fail to save in the first place? Seems like an arbitrary point to add a localized notification...
You're the one that added the check. If its unexpected behavior, throw.
There was a problem hiding this comment.
Btw, on the localized notification thing - does it need to be localized? I mean, you can just pass a string to the notifications, right?
There was a problem hiding this comment.
I didn't add anything. I just moved the code.
Also, what would a user faced message achieve if I'm not an english speaker and some random text appears for 3 seconds?
| { | ||
| home_menu_entry::home_menu_entry(const std::string& text) | ||
| { | ||
| std::unique_ptr<overlay_element> text_stack = std::make_unique<vertical_layout>(); |
There was a problem hiding this comment.
Again, these can be objects.
// In header file
vertical_layout m_text_stack;There was a problem hiding this comment.
add_element takes a unique_ptr and moves it
