VSH Improvements #13172
Merged
VSH Improvements #13172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
|
Last commit adds VSH to game grid, with all it entails such as custom config and shortcut creation.
|
|
Please stop mixing GUI stuff with HLE bugfixes |
|
@Darkhost1999 Please retest. |
|
RPCS3.log |
|
Working well for me |
Megamouse
reviewed
Jan 7, 2023
kd-11
reviewed
Jan 7, 2023
brian218
reviewed
Jan 7, 2023
kd-11
reviewed
Jan 7, 2023
kd-11
reviewed
Jan 7, 2023
kd-11
approved these changes
Jan 9, 2023
kd-11
reviewed
Jan 9, 2023
Nekotekina
reviewed
Jan 9, 2023
| @@ -394,7 +394,7 @@ const std::array<std::pair<ppu_intrp_func_t, std::string_view>, 1024> g_ppu_sysc | |||
| BIND_SYSC(sys_memory_container_destroy), //342 (0x156) | |||
| BIND_SYSC(sys_memory_container_get_size), //343 (0x157) | |||
| NULL_FUNC(sys_memory_budget_set), //344 (0x158) | |||
| null_func,//BIND_SYSC(sys_memory_...), //345 (0x159) | |||
There was a problem hiding this comment.
Missing PPUFunction naming I suppose
There was a problem hiding this comment.
The function in PPUFunction.cpp has been removed a long time ago in favour of inlined naming in this array.
There was a problem hiding this comment.
Right, I'm thinking of syscall list in PPU link table in PPUThread.cpp
There was a problem hiding this comment.
That's also fine because all "syscall_0"-"syscall_1023" names are linked by default.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes allow to proceed further along into game launching within XMB.
Fixes #13154