Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Properly reset ZCULL stat counters #12645

Merged
merged 2 commits into from
Sep 12, 2022
Merged

rsx: Properly reset ZCULL stat counters #12645

merged 2 commits into from
Sep 12, 2022

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Sep 12, 2022

Fixes #12635

@Darkhost1999
Copy link
Contributor

I saw these yesterday when not using this PR. I didn't know what to think they looked out of place but I ignored them.
Suggestion: If this shouldn't happen can we maybe append to the log message "this shouldn't happen" or something?
Screenshot_20220912-082732_GitHub.png
I'm just thinking like other errors with the "report to developers" messages.

@kd-11
Copy link
Contributor Author

kd-11 commented Sep 12, 2022

I saw these yesterday when not using this PR. I didn't know what to think they looked out of place but I ignored them. Suggestion: If this shouldn't happen can we maybe append to the log message "this shouldn't happen" or something? Screenshot_20220912-082732_GitHub.png I'm just thinking like other errors with the "report to developers" messages.

How to reproduce that?

@kd-11 kd-11 merged commit 572a2a0 into RPCS3:master Sep 12, 2022
@Darkhost1999
Copy link
Contributor

How to reproduce that?

It seems just by playing shadow of Mordor. Conveniently or inconveniently I got the message again immediately after my controller batteries died.
image
I saw more than 1 of these messages yesterday and now I gotta update and confirm this is still an issue.
Because is that error something this PR could have fixed?
RPCS3.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Demon's Souls - Sun shines through solid objects (Again?)
2 participants