Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type hint #173

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Correct type hint #173

merged 1 commit into from
Sep 11, 2024

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Sep 9, 2024

No description provided.

Copy link

github-actions bot commented Sep 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mawong-amd
Copy link

mawong-amd commented Sep 9, 2024

Let's change this in upstream rather than doing this separate PR. Unless there's a functionality improvement.

Copy link

@mawong-amd mawong-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as this PR fixes and enables the use of Cython, which was broken as detailed here.

@mawong-amd
Copy link

The incorrect type hint originated from vllm-project#7049

@mawong-amd mawong-amd merged commit dc948ab into main Sep 11, 2024
16 checks passed
@mawong-amd mawong-amd deleted the type_hint_fix branch September 11, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants