MIVisionX compatibility fix - Resample and preemphasis filter #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Aug 27, 2024
r-abishek
commented
- Move out the windowed_sinc function from rppdefs.h and readded vector usage for lookup table for compatibility
- Disable the numDims validation for preemphasis HOST kernel temporarily
…ith older rpp builds
disabled numDims validation check for preemphasis HOST kernel
…anges Resample and preemphasis filter compatibility changes for MIVisionX
rrawther
reviewed
Aug 27, 2024
| @@ -316,4 +316,46 @@ void verify_non_silent_region_detection(int *detectedIndex, int *detectionLength | |||
| qaResults << status << std::endl; | |||
| qaResults.close(); | |||
| } | |||
| } | |||
|
|
|||
| inline Rpp32f sinc(Rpp32f x) | |||
There was a problem hiding this comment.
when we enable RPP HIP audio, we need to remove these from here and MIVisionX. To do that you can use a new RPP version and check that
rrawther
approved these changes
Aug 27, 2024
kiritigowda
changed the title
HazarathKumarM
pushed a commit
to HazarathKumarM/rpp
that referenced
this pull request
Aug 29, 2024
* modified windowed_sinc function to resolve the compatibility issues with older rpp builds * incremented RPP_VERSION_PATCH value disabled numDims validation check for preemphasis HOST kernel --------- Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.