RPP Tensor Transpose ND on HOST and HIP #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made changes in test suite to read read fixed input and comparision with golden output
made changes to update destination strides based on permute order
added golden input and outputs for 3D [2, 0, 1] transpose version removed golden inputs and outputs for 6D data
Transpose ND HIP Kernel Optimizations
rrawther
reviewed
Jun 13, 2024
| rpp_simd_store(rpp_store4_f32_to_f32, dstPtrRow[6], &pDst[6]); | ||
| rpp_simd_store(rpp_store4_f32_to_f32, dstPtrRow[7], &pDst[7]); | ||
|
|
||
| srcPtrRow[0] += vectorIncrement; |
There was a problem hiding this comment.
Can you can combine 8 of these increamets into single avx instruction?
rrawther
requested review from
rrawther and
AryanSalmanpour
and removed request for
a team
minor formatting changes
Transpose changes based on review comments
AryanSalmanpour
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Tensor Transpose ND on HOST and HIP
Adds relevant Unit/Perf/QA tests