HIP build corrections #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Oct 28, 2020
r-abishek
commented
- Fix HIP backend issues
- Changes for hip build
- Change cmakelists for linking issues
- Change include hip/hip_hcc.h to hip/hip_ext.h to avoid warning
Fix pln1 issues in testsuite Fix other minor bugs
|
Issues
======
+ Solved 3
Clones removed
==============
+ src/modules/hip/hip_morphological_transforms.cpp -17
+ src/modules/hip/hip_color_model_conversions.cpp -27
+ src/modules/hip/hip_imgaugmentation.cpp -19
+ src/modules/hip/hip_filter_functions.cpp -6
See the complete overview on Codacy |
|
@LakshmiKumar23 can you check this PR |
LakshmiKumar23
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
@kiritigowda builds successfully on both rocm3.7 and rocm3.8
rrawther
reviewed
Dec 8, 2020
| stdDev | ||
| ); | ||
| } | ||
| // int ctr=0; |
There was a problem hiding this comment.
if we are not using these implementations anymore, it is better to remove the entire function
There was a problem hiding this comment.
For all the commented functions in this file
| // gDim3[2] = 1; | ||
| // cl_kernel_implementer (handle, gDim3, NULL/*Local*/, theProgram, theKernel); | ||
| } | ||
| // srand(time(0)); |
There was a problem hiding this comment.
Is this not used anymore? Better to remove the function all together
| kernelSize | ||
| ); | ||
| } | ||
| // int ctr=0; |
There was a problem hiding this comment.
please remove all the irrelevant code
fiona-gladwin
pushed a commit
to fiona-gladwin/rpp
that referenced
this pull request
Dec 22, 2021
…or_mods Resize Bilinear : Tensor Code clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.