RPP - 1.4 #238
Merged
RPP - 1.4 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritigowda
commented
Oct 23, 2023
| @@ -163,8 +162,8 @@ set(LINK_LIBRARY_LIST ${LINK_LIBRARY_LIST} Threads::Threads) | |||
| # -fPIC -- Generate position-independent code if possible. | |||
| # -mavx2 -- Support MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AVX and AVX2 built-in functions and code generation. | |||
| # -mfma -- Support MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AVX and FMA built-in functions and code generation. | |||
| # -std=gnu++14 -- Conform to the ISO 2014 C++ standard with GNU extensions. | |||
There was a problem hiding this comment.
@hansely - Added this for C17
kiritigowda
commented
Oct 23, 2023
| @@ -126,9 +126,6 @@ if("${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_BINARY_DIR}") | |||
| endif() | |||
| list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake) | |||
|
|
|||
| # Filesystem support | |||
| set(LINK_LIBRARY_LIST ${LINK_LIBRARY_LIST} stdc++fs) | |||
There was a problem hiding this comment.
@hansely - removed this as not required with c17 - verify
kiritigowda
commented
Oct 23, 2023
| @@ -263,8 +262,6 @@ else() | |||
| message("-- ${Red}${PROJECT_NAME} set to build without ENABLE_SIMD_INTRINSICS${ColourReset}") | |||
| endif() | |||
|
|
|||
|
|
|||
| set(LINK_LIBRARY_LIST ${LINK_LIBRARY_LIST} stdc++) | |||
There was a problem hiding this comment.
@hansely - not required with C17 - verify
kiritigowda
added a commit
that referenced
this pull request
Oct 23, 2023
* RPP - 1.4 * macOS - Build Fix * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPP 1.4.0 Release