RPP OpenMP threads update #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d crop and cmn augmentations made changes to set numthreads as batchsize if numthreads value is 0
Changes for setting number of threads used in OpenMP for HOST functions
rrawther
reviewed
Mar 31, 2023
|
@r-abishek does this PR break functionality/build with the current version of MIVisionX? if yes, can we update the RPP version to |
rrawther
reviewed
Mar 31, 2023
|
@kiritigowda Yes, the numThreads needs to be passed to RPP functions from MIVisionX, and that will be a separate PR in MIVisionX. We'll run tests and confirm compatibility next week before merging either PRs. |
rrawther
requested changes
Mar 31, 2023
added description for numThreadsin readme and test suite files
Default value for numThreads used for OpenMp
rrawther
reviewed
Apr 12, 2023
rrawther
approved these changes
Apr 12, 2023
Added default value for numthreads for internal handle creation call in HIP
|
@kiritigowda This PR can be merged along with PR1060 in MIVisionX |
RPP Version update for backward compatibility failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kiritigowda @rrawther This PR needs to be merged together with an upcoming PR in MIVisionX for ToT to be in sync.
The MIVisionX PR will be issued in the next few days. The RPP#143 and MIVisionX PRs can be tested merged after that.
Adds numThreads as a parameter in RPP handle for HOST backend functionalities.
Modifies all BatchPD and Tensor functionalities with a common change to use this numThreads parameter