Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync develop for ROCm 6.4 #479

Merged
merged 48 commits into from
Dec 18, 2024
Merged

Sync develop for ROCm 6.4 #479

merged 48 commits into from
Dec 18, 2024

Conversation

cgmillette
Copy link
Contributor

  • Adds interleaved infrastructure
  • Implements register formats and transforms
  • Updates ROCm 6.4 docs
  • Replaces AMDGPU_TARGETS with GPU_TARGETS
  • uses --offload-compress

dependabot bot and others added 30 commits November 25, 2024 17:53
@dependabot
Bump rocm-docs-core from 1.8.3 to 1.9.0 in /docs/sphinx
c39b14a 
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.9.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.9.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.8.3...v1.9.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@cgmillette
Merge pull request #465 from ROCm/dependabot/pip/docs/sphinx/rocm-doc…
c4e8d43 
…s-core-1.9.0

Bump rocm-docs-core from 1.8.3 to 1.9.0 in /docs/sphinx
@cgmillette
Serialize GEMM kernel runs
a455d3f
@cgmillette
First working interleaved 128x128 macro kernel
5337ba8
@cgmillette
Initial layout classes refactor
ce0f116
@cgmillette
Refactor layout and traits organization
cdd13bc
@cgmillette
Remove unused file
e15f5b0
@cgmillette
Refactor layout traits
c27e4e1
@cgmillette
Fixes build after layout folder refactor
f27ed38
@cgmillette
Update interleaving function
f3622e3
@cgmillette
Update is_layout_same and is_layout_orthogonal and matrix layouts logic
2c550c3
@cgmillette
Introduce register formats and refactor is_layout_same and is_layout_…
64da221 
…orthogonal logic
@cgmillette
Fixup interleaved layouts logic bugs. Add layout formats to fit all w…
b222868 
…orkflows
@cgmillette
Fix compiler unroll issue with function arg
a5c23e4
@cgmillette
Deploy new mma workflow
678a2d3
@cgmillette
Fix include issues and io_shape test
622a256
@cgmillette
Add interleaved layout IOLayoutInt
2c08b36
@cgmillette
Fixes for interleaved layout compatibility
d89b536
@cgmillette
Add initial non-interleaved layout traits test
f6ff3e4
@cgmillette
Add DataT to Mma layout interface. Add checks for data size comparison
9cc7ebc
@cgmillette
Fixes f64 tests. Adds all block sizes tests.
368c6dc
@cgmillette
Start implementing interleaved layout traits tests
d88e353
@cgmillette
Add interleaved and emulation tests
31e2f5a
@cgmillette
Fix build of layout unit tests
ef05816
@dependabot
Bump rocm-docs-core from 1.9.0 to 1.9.2 in /docs/sphinx (#467)
5e8d2f6 
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.9.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.9.0...v1.9.2)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cgmillette
Update CODEOWNERS
365b02e
@cgmillette
Fix gfx11 implementation
b875471
@cgmillette
Restore perf_hgemm
b035289
@cgmillette
Skip tests on invalid layout condition for BlockK
43c96fe
@cgmillette
Add a softer warning for unsupported transform attempts
1aeb382
CongMa13 and others added 18 commits December 3, 2024 15:34
@CongMa13
Updated changelog and set version to 1.7.0
8ee5c17
@CongMa13
Updated docs
0055868 
- Updated target list
- Add emulation test docs
@CongMa13 @amd-jnovotny
Improve docs formatting
656972e 
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com>
@cgmillette
Adjust MaxVWSelector to fit more layout constraints
abb085f
@cgmillette
Update / correct non-interleaved layout tests
a420f9b
@cgmillette
Prevent sgemm kernel from building on unsupported targets
e494ec1
@cgmillette
Fixes: remove default Format argument to avoid usage mistakes; fix te…
8c75e88 
…st cases for gfx11 MmaInput and MmaAcc; fix MaxVW selector to fit proper layout fitness
@cgmillette
Fixup interleaved tests on gfx11
73fb53c
@dlangbe @cgmillette
Minor CMake Changes (#466)
d2d13e3 
* updated AMDGPU_TARGETS to GPU_TARGETS and checked for --offload-compress

* Addressed comments

* Added BUILD_OFFLOAD_COMPRESS

* Apply suggestions from code review

* Update test/CMakeLists.txt

---------

Co-authored-by: Christopher Millette <63608002+cgmillette@users.noreply.github.com>
@dependabot
Bump rocm-docs-core from 1.9.2 to 1.11.0 in /docs/sphinx (#474)
fc3a273 
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.2 to 1.11.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.9.2...v1.11.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cgmillette
Allow acc post mma xform to convert gfx11 mma acc quirk into configur…
4d6fab8 
…ation
@cgmillette
Fixup MmaDim calculator
e3c61a3
@cgmillette
Removed WMMA_ACC_INT* formats
61274d0
@cgmillette
removes std min reference for hipRTC
45cf20e
@cgmillette
Update CMakeLists.txt
d13b2f3 
Test to see if linking issues fixed
@cgmillette
Merge pull request #478 from ROCm/cgmillette-patch-2
ada4c03 
Fixes large binary rpath change failure
@cgmillette
Update perf_hgemm.cpp
19af315 
fix newline
@cgmillette
Merge pull request #472 from cgmillette/interleave-dev
c831ff5 
Interleave dev
amd-jnovotny
amd-jnovotny approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (seems to be a straightforward merge)

@samjwu
Copy link
Member

samjwu commented Dec 18, 2024

passing build http://math-ci.amd.com/job/main/job/precheckin/job/rocWMMA/view/change-requests/job/PR-479/1/

@cgmillette cgmillette merged commit 6b8f92f into release-staging/rocm-rel-6.4 Dec 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@CongMa13 CongMa13 CongMa13 approved these changes

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@dlangbe dlangbe Awaiting requested review from dlangbe dlangbe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cgmillette @samjwu @CongMa13 @amd-jnovotny @dlangbe