initial steps, cmake build chain, tests, benchmarks, interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I skimmed through the files; looks like you have covered cmake build system, unit tests, samples, logging, benchmarking, and more; looks great; did you use build templates from rocBLAS? I am also interested in discussing public api and how flexible it is.. feel free to merge |
ntrost57
added a commit
that referenced
this pull request
Dec 17, 2019
* do not allow non-squared matrices in csrsv test/bench * fixed wrong logfile name for scsrmv and scsrsv scripts * new performance scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.