Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of metrics and documentation for Omniperf profiling #224

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

skyreflectedinmirrors
Copy link
Contributor

@skyreflectedinmirrors skyreflectedinmirrors commented Jan 16, 2024

This PR contains the collective work of many AMDer's (including myself, @gsitaram, @IanBogle, @rajaroracmu, @ausellis0, @coleramos425, @rwvo, @jlgreathouse and others) that:

  • Reworks Omniperf metrics for existing CDNA accelerators (e.g., MI250) for improved user experience / usability, etc.
  • Adds full documentation of the updated metrics
  • Adds several examples, and discussion of using Omniperf on said examples

@dmcdougall
Copy link

@skyreflectedinmirrors Are you looking for feedback on this yet?

@skyreflectedinmirrors
Copy link
Contributor Author

For sure, any feedback / corrections are welcome. I will note that:

  • A) this isn't intended to be a profiling guide, more "what do these mean"
  • B) the scope doesn't include MI300's (yet)

Feel free to reach out to me internally as well for any specific questions that might not be suitable for a public discussion

Nicholas Curtis added 10 commits January 26, 2024 11:19
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
sample/fabric.hip Outdated Show resolved Hide resolved
Copy link
Collaborator

@coleramos425 coleramos425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest modifying copyrights in the new sample code to include our delimiters. This way things are compatible with utils/update_license.py

sample/instmix.hip Outdated Show resolved Hide resolved
sample/ipc.hip Outdated Show resolved Hide resolved
sample/lds.hip Outdated Show resolved Hide resolved
sample/occupancy.hip Outdated Show resolved Hide resolved
sample/stack.hip Outdated Show resolved Hide resolved
sample/vcopy.cpp Outdated Show resolved Hide resolved
sample/vmem.hip Outdated Show resolved Hide resolved
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
@coleramos425 coleramos425 merged commit d27a415 into ROCm:dev Jan 29, 2024
6 of 9 checks passed
coleramos425 added a commit that referenced this pull request Feb 1, 2024
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
coleramos425 added a commit that referenced this pull request Feb 1, 2024
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
coleramos425 added a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
coleramos425 added a commit that referenced this pull request Feb 6, 2024
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants