-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of metrics and documentation for Omniperf profiling #224
Rework of metrics and documentation for Omniperf profiling #224
Conversation
5b962b5
to
91968eb
Compare
@skyreflectedinmirrors Are you looking for feedback on this yet? |
For sure, any feedback / corrections are welcome. I will note that:
Feel free to reach out to me internally as well for any specific questions that might not be suitable for a public discussion |
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
f2d61ce
to
b1d6fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest modifying copyrights in the new sample code to include our delimiters. This way things are compatible with utils/update_license.py
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
626d0e0
to
80c3f59
Compare
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
This PR contains the collective work of many AMDer's (including myself, @gsitaram, @IanBogle, @rajaroracmu, @ausellis0, @coleramos425, @rwvo, @jlgreathouse and others) that: